flexible restart writing in UFS#1651
Conversation
Modify mom_cap.F90 so that restart writes can be triggered at any forecast time via UFS configuration as for other components
…n-20241127 update to main repo. 20250113 commit (20241127-PR)
jiandewang
requested review from
abozec,
alperaltuntas,
kshedstrom,
marshallward and
mathomp4
abozec
left a comment
abozec
left a comment
There was a problem hiding this comment.
COAPS is not using the nuopc_cap so we approve ...
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
In general, we are not very happy with the use of CPP macros, as it leads to code that might not even compile, but in this case this is an extension of macros that already exist and are in use to accommodate differences between the CESM version of the NUOPC coupler and the version used by other people. We might want to think more carefully about whether there are other non-EMC and non-CESM folks who are using the NUOPC coupler and might need to be consulted with these changes.
That being said, GFDL does not use the NUOPC cap for our configurations, so this would not be a problem from our end. (@marshallward will need to issue the formal approval from the GFDL side.)
|
@Hallberg-NOAA Your approval counts towards the total approval, so nothing more is needed from GFDL. Although it's "one vote per node", there's no way to enforce this in GitHub, so centers with multiple approvers have to self-enforce this. (I have removed myself from the reviewer list.) |
mathomp4
left a comment
mathomp4
left a comment
There was a problem hiding this comment.
GEOS does not compile this file, so easy approve.
kshedstrom
left a comment
kshedstrom
left a comment
There was a problem hiding this comment.
I am not using this file. either.
|
@alperaltuntas did you get a chance to check this PR ? |
…vers/nuopc_cap/mom_cap.F90
Encapsulate init_is_restart_fh in ifndef CESMCOUPED
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
- Coverage 37.05% 36.64% -0.41%
==========================================
Files 271 278 +7
Lines 81272 84342 +3070
Branches 15162 15903 +741
==========================================
+ Hits 30112 30904 +792
- Misses 45523 47593 +2070
- Partials 5637 5845 +208 ☔ View full report in Codecov by Sentry. |
|
thanks for everybody's time to review this PR. I am going to merge it. |
8 participants
This mini PR add the capability of flexible restart write times which is controlled by "restart_fh" for all subcomponents (ocean, ice, wave and mediator) in UFS. Detail can be found at NOAA-EMC#139
The only file that is being modified is mom_cap.F90
Thanks for @alperaltuntas to pre-test this in NCAR system